MBVM-89: Show info about signing up on first fetch #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
reviewed
Apr 24, 2023
It shows information about signing up when fetching data (database and/or search indexes) dumps, for commercial or non-commercial use. It doesn’t show it for fetching sample dump which is for development. It doesn’t show it again for further downloads if answered already. To do that, it creates an empty file in the database dump directory. If we need to update any of these messages in the future, we can compare the timestamp of this file to show the updated message.
yvanzo
force-pushed
the
mbvm-89-info-dl
branch
2 times, most recently
from
ed5987f
to
243f95f
Compare
mayhem
approved these changes
Apr 24, 2023
| if [[ ${REPLY:0:1} =~ [Yy] ]] | ||
| then | ||
| prompt=$(cat <<-EOQ | ||
| The MetaBrainz Foundation is supported by commercial users of our data and |
There was a problem hiding this comment.
I think that the duplication of the text is not great, since that is bound to get out of sync. Would it be possible to have the text defined in a single file, that then gets used by these two files?
There was a problem hiding this comment.
It is a known general issue that many things are duplicated between build contexts for production and development versions of MusicBrainz server. This script is the same for both but others have small differences. There is no way to use symbolic links here and having a common build context would be more overhead.
reosarevok
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem MBVM-89
There is a lack of information about the sign-up process when downloading data without using the live data feed (which already requires signing up in practice to get a replication token).
Solution
It shows information about signing up when fetching data (database and/or search indexes) dumps, for commercial or non-commercial use.
It doesn’t show it for fetching sample dump which is for development.
It doesn’t show it again for further downloads if answered already. To do that, it creates an empty file in the database dump directory. If we need to update any of these messages in the future, we can compare the timestamp of this file to show the updated message.
Progress